Fix kanban quick input to send literal text via tmux#521
Merged
Conversation
sendTextToExecutor was using SendKeyToPane which passes user text directly to tmux send-keys without the -l flag. If user text matched a tmux key name (e.g. "Enter", "Escape", "Space"), it would be interpreted as a key press instead of literal text. Added SendLiteralTextToPane that uses -l for the text portion and sends Enter separately. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendTextToExecutorusedSendKeyToPanewhich passes user text totmux send-keyswithout the-l(literal) flag. If user input matched a tmux key name (e.g. "Enter", "Escape", "Space", "Tab"), it would be interpreted as a key press instead of literal text.SendLiteralTextToPanethat sends text with-lflag (ensuring literal interpretation), then sends Enter as a separate key press.TestQuickInput_EnterWithTextSendsAndUnfocusesandTestQuickInput_EnterWithTextNoSelectedTaskto cover the send-text-on-enter path and the nil-task edge case.Audit findings
The kanban quick input function mostly works but had one correctness bug:
-lflag for literal textTest plan
QuickInputtests passui,executor,db,config)🤖 Generated with Claude Code